Skip to content

Remove unreasonable help message for auto trait #105817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2022
Merged

Remove unreasonable help message for auto trait #105817

merged 1 commit into from
Dec 27, 2022

Conversation

chenyukang
Copy link
Member

Fixes #105788

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2022

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2022
@chenyukang
Copy link
Member Author

There is another solution, we just emit E0380, and use items with an empty vec in:

rust/compiler/rustc_parse/src/parser/item.rs

Line 876 in 49c2279

ItemKind::Trait(Box::new(Trait { is_auto, unsafety, generics, bounds, items })),

Then, in later parts we don't need care about auto trait, since we have made sure there will be no assoc items in it.

I'm not sure whether this is a desirable solution, but it seems more completed than our current case by case fix.

@TaKO8Ki how do you think?

@chenyukang
Copy link
Member Author

I tried this solution, it's also a fix for #105732:

e2e9a31

Not sure which fix is better.
@compiler-errors

TaKO8Ki
TaKO8Ki reviewed Dec 26, 2022
View reviewed changes
Copy link
Member

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Dec 26, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 26, 2022

📌 Commit 359d667d19436fae7028c79bc911155f17c0a7af has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2022
@bors
Copy link
Collaborator

bors commented Dec 26, 2022

⌛ Testing commit 359d667d19436fae7028c79bc911155f17c0a7af with merge 14e7a8c003fd680addec20f14c51c2cf63cadf6e...

@bors
Copy link
Collaborator

bors commented Dec 26, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang/fix-105788-sugg-for-auto-trait branch from 359d667 to 90753de Compare December 27, 2022 07:14
@compiler-errors
Copy link
Member

This failure is unrelated to the PR.

@bors r=TaKO8Ki

@bors
Copy link
Collaborator

bors commented Dec 27, 2022

📌 Commit 90753de has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106183 - matthiaskrgr:rollup-ww6yzhi, r=matth…
db79625 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#105817 (Remove unreasonable help message for auto trait)
 - rust-lang#105994 (Add regression test for rust-lang#99647)
 - rust-lang#106066 (Always suggest as `MachineApplicable` in `recover_intersection_pat`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a0bf4f9 into rust-lang:master Dec 27, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 27, 2022
@ehuss ehuss mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaKO8Ki TaKO8Ki TaKO8Ki left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Invalid suggest for methods in auto trait
6 participants
@chenyukang @rustbot @TaKO8Ki @bors @rust-log-analyzer @compiler-errors